Add bust_cache param to fix stale featured workshops#1300
Merged
Conversation
Featured workshop IDs are cached for 1 year and the before_save invalidation can race with the save transaction, leaving stale data. Visiting /?bust_cache=true now clears and repopulates the cache. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maebeale
changed the title
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maebeale
changed the title
The test env uses :null_store by default, so the stale cache scenario was untestable — every request re-executed the fetch block. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The workshop factory's before_save callback invalidates the cache when featured changes, so we manually write stale data back to simulate the race condition the test is verifying. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
before_save, which runs inside the save transaction — if another request repopulates the cache before the transaction commits, stale data persists indefinitelyHow did you approach the change?
bust_cache=trueURL param support toHome::WorkshopsController— deletes the cached IDs before re-fetching_workshops.html.erbso visiting/?bust_cache=truebusts the cache server-wideUI Testing Checklist
/— featured workshops section loads normally/?bust_cache=true— featured workshops appear (cache refreshed)Anything else to add?
before_save→ transaction race condition is the root cause,bust_cacheis a manual escape hatch🤖 Generated with Claude Code